RB 1.7.21.

I've noticed that the response to Download Diff includes a 
Content-Disposition: inline:

GET /r/1234/diff/raw/ HTTP/1.1

Content-Type: text/x-patch
Content-Disposition: *inline*; filename=some.patch

Shouldn't that be:

Content-Disposition: *attachment*; filename=some.patch

 ?  Current Chrome version sees text/ MIME type and displays the content 
inline (in the current window) as suggested, instead of raising a download 
dialog.  I image most if not all folks clicking "Download Diff" want the 
patch as a file, otherwise they would click "View Diff".

Has this come up before?  Raise a bug?


Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
Happy user? Let us know at http://www.reviewboard.org/users/
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to