Thanks, done, https://code.google.com/p/reviewboard/issues/detail?id=3384 .
On Saturday, May 24, 2014 5:26:19 AM UTC+10, Christian Hammond wrote: > > Okay, I'm happy switching it over then. Would you mind filing a bug (or a > review request, if you want to just make the switch)? We can get it in for > a 2.0.x. > > Christian > > -- > Christian Hammond - [email protected] <javascript:> > Review Board - http://www.reviewboard.org > Beanbag, Inc. - http://www.beanbaginc.com > > > On Thu, May 22, 2014 at 6:50 PM, Brett Randall <[email protected]<javascript:> > > wrote: > >> Thanks Christian. I ran blame to find the commit where this was added, >> and commented: >> >> >> https://github.com/reviewboard/reviewboard/commit/ed3e2a4382aeaf4155dabe67a2d259ca72362096 >> >> So I think the drive here was to ensure that the patch filename is >> retained, but "attachment" might be more appropriate than "inline" for raw >> diff requests. >> >> Thanks >> Brett >> >> >> On Friday, May 23, 2014 11:37:16 AM UTC+10, Christian Hammond wrote: >> >>> Hi Brett, >>> >>> It's actually never come up before, that I know of. It may be more >>> useful to do that, but I think it's arguable. Certainly, I sometimes view >>> the diff and am happy looking at it right in the browser, instead of having >>> to save it somewhere and then open it. >>> >>> I'm interested in hearing what others have to say. >>> >>> Christian >>> >>> -- >>> Christian Hammond - [email protected] >>> >>> Review Board - http://www.reviewboard.org >>> Beanbag, Inc. - http://www.beanbaginc.com >>> >>> >>> On Thu, May 22, 2014 at 6:25 PM, Brett Randall <[email protected]>wrote: >>> >>>> Hi, >>>> >>>> RB 1.7.21. >>>> >>>> I've noticed that the response to Download Diff includes a >>>> Content-Disposition: inline: >>>> >>>> GET /r/1234/diff/raw/ HTTP/1.1 >>>> >>>> Content-Type: text/x-patch >>>> ... >>>> Content-Disposition: *inline*; filename=some.patch >>>> >>>> >>>> Shouldn't that be: >>>> >>>> Content-Disposition: *attachment*; filename=some.patch >>>> >>>> >>>> ? Current Chrome version sees text/ MIME type and displays the >>>> content inline (in the current window) as suggested, instead of raising a >>>> download dialog. I image most if not all folks clicking "Download Diff" >>>> want the patch as a file, otherwise they would click "View Diff". >>>> >>>> Has this come up before? Raise a bug? >>>> >>>> Thanks >>>> Brett >>>> >>>> -- >>>> Get the Review Board Power Pack at http://www.reviewboard.org/ >>>> powerpack/ >>>> --- >>>> Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ >>>> --- >>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "reviewboard" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
