----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46860/#review131350 -----------------------------------------------------------
ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 85) <https://reviews.apache.org/r/46860/#comment195277> Good idea. Let me see if I can add HAWQ dynamically at onLoadConfigsTags(). ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 582) <https://reviews.apache.org/r/46860/#comment195276> I will keep this logic here as this is the first loation the logic can see cluster information and the definitions can get modified. getConfigUrlParams() is to generate a list of partial URLs. The second suggestion is good and I will invert this if statement and remove them from the default values. - jun aoki On April 29, 2016, 11:57 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46860/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 11:57 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-16174 > https://issues.apache.org/jira/browse/AMBARI-16174 > > > Repository: ambari > > > Description > ------- > > when RM HA is not enabled, following properties should be updated in > hawq-site.xml should be updated. > hawq_rm_yarn_address > hawq_rm_yarn_scheduler_address > When RM HA Is enabled and then a RM is moved, following properties in > yarn-client.xml should be updated > yarn.resourcemanager.ha > yarn.resourcemanager.scheduler.ha > > > Diffs > ----- > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > a20aa82 > ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 460726b > > Diff: https://reviews.apache.org/r/46860/diff/ > > > Testing > ------- > > Unit test passed > Calling set on destroyed view > > 27428 tests complete (35 seconds) > 154 tests pending > > > Manually tested > > > Thanks, > > jun aoki > >
