> On May 2, 2016, 10:16 p.m., Matt wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > <https://reviews.apache.org/r/46860/diff/2/?file=1369090#file1369090line85>
> >
> >     If HAWQ is configured to work on Standalone mode, should HAWQ be in the 
> > list of services to stop/start when some operation is done with YARN 
> > service? Can this be appended to this list based on what type of resource 
> > management HAWQ is relying on?
> >     
> >     I would configure HAWQ in standalone mode, and move YARN Resource 
> > Manager - I would not expect HAWQ to be restarted in this case.

@Matt, please my comment on May 2, 2016, 8:57 p.m.


> On May 2, 2016, 10:16 p.m., Matt wrote:
> > ambari-web/app/utils/configs/move_rm_config_initializer.js, line 120
> > <https://reviews.apache.org/r/46860/diff/2/?file=1369091#file1369091line120>
> >
> >     The line numbers on the link does not stick when the file in that 
> > repository gets updated.

It is to a release tag, so hopefuly won't be updated.


- jun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131391
-----------------------------------------------------------


On May 2, 2016, 9:47 p.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
>     https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> -------
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Reply via email to