----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52411/#review150977 -----------------------------------------------------------
ambari-server/src/main/python/ambari_server/utils.py (line 169) <https://reviews.apache.org/r/52411/#comment219080> Doesn't this connect need a timeout? ambari-server/src/main/python/ambari_server/utils.py (line 170) <https://reviews.apache.org/r/52411/#comment219079> Typo: Server started listening on port ambari-server/src/main/python/ambari_server/utils.py (line 179) <https://reviews.apache.org/r/52411/#comment219081> We are waiting for pid already right, so why wait again? - Sid Wagle On Sept. 29, 2016, 10:58 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52411/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 10:58 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18501 > https://issues.apache.org/jira/browse/AMBARI-18501 > > > Repository: ambari > > > Description > ------- > > If due to some error, ambari-server JAR exits with -1, we still display > “Ambari Server ‘start’ completed successfully” > In AmbariServer.java::main(), if an exception occurs, the program exits with > -1. Howerver, the caller ambari-server.py::main() displays the status message > as "Ambari Server 'start' completed successfully". > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/utils.py 012d428 > ambari-server/src/main/python/ambari_server_main.py 57ec58d > ambari-server/src/test/python/TestUtils.py db94d92 > > Diff: https://reviews.apache.org/r/52411/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
