----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52411/#review151042 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/python/ambari_server/utils.py (line 153) <https://reviews.apache.org/r/52411/#comment219162> convert to int here instead of inside while ambari-server/src/main/python/ambari_server/utils.py (line 158) <https://reviews.apache.org/r/52411/#comment219163> pids isn't changing inside the while block, can move the check len(pids) > 0 before it. ambari-server/src/main/python/ambari_server/utils.py (line 179) <https://reviews.apache.org/r/52411/#comment219164> Don't hardcode the "55" seconds ambari-server/src/main/python/ambari_server_main.py (line 104) <https://reviews.apache.org/r/52411/#comment219165> Add comment that these are in seconds. - Alejandro Fernandez On Sept. 30, 2016, 1:50 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52411/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2016, 1:50 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18501 > https://issues.apache.org/jira/browse/AMBARI-18501 > > > Repository: ambari > > > Description > ------- > > If due to some error, ambari-server JAR exits with -1, we still display > “Ambari Server ‘start’ completed successfully” > In AmbariServer.java::main(), if an exception occurs, the program exits with > -1. Howerver, the caller ambari-server.py::main() displays the status message > as "Ambari Server 'start' completed successfully". > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/utils.py 012d428 > ambari-server/src/main/python/ambari_server_main.py 57ec58d > ambari-server/src/test/python/TestUtils.py db94d92 > > Diff: https://reviews.apache.org/r/52411/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >