> On Вер. 30, 2016, 2:20 до полудня, Sid Wagle wrote:
> > ambari-server/src/main/python/ambari_server/utils.py, line 169
> > <https://reviews.apache.org/r/52411/diff/1/?file=1516490#file1516490line169>
> >
> >     Doesn't this connect need a timeout?

It depends on mode (blocking/non blocking) and it works fine but to be sure and 
safe i've added timeout.


> On Вер. 30, 2016, 2:20 до полудня, Sid Wagle wrote:
> > ambari-server/src/main/python/ambari_server/utils.py, line 179
> > <https://reviews.apache.org/r/52411/diff/1/?file=1516490#file1516490line179>
> >
> >     We are waiting for pid already right, so why wait again?

Here we are waiting for 10 seconds to initialize WEB UI after port was 
occupied. And in this loop i'm checking pid and process is alive.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52411/#review150977
-----------------------------------------------------------


On Вер. 30, 2016, 10:07 до полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52411/
> -----------------------------------------------------------
> 
> (Updated Вер. 30, 2016, 10:07 до полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18501
>     https://issues.apache.org/jira/browse/AMBARI-18501
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If due to some error, ambari-server JAR exits with -1, we still display 
> “Ambari Server ‘start’ completed successfully”
> In AmbariServer.java::main(), if an exception occurs, the program exits with 
> -1. Howerver, the caller ambari-server.py::main() displays the status message 
> as "Ambari Server 'start' completed successfully".
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/utils.py 012d428 
>   ambari-server/src/main/python/ambari_server_main.py 57ec58d 
>   ambari-server/src/test/python/TestUtils.py db94d92 
> 
> Diff: https://reviews.apache.org/r/52411/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to