> On Oct. 7, 2016, 3:39 p.m., Nate Cole wrote:
> > This code is breaking tests, and has been reverted from trunk.  Please fix 
> > the tests, and also fix the formatting.  Ambari is standardized on two 
> > space tabs.  DependencyConditionInfo is a undocumented and unformatted 
> > class.  In addition, you shouldn't be making subclasses as internal classes 
> > of the parent abstract class.
> > 
> > Di Li, when you commit code on behalf of someone else, you must make the 
> > message like so: "AMBARI-XXXXX. Some message (Joe Smith via dili)"
> 
> Di Li wrote:
>     Anything else you think I should put in as the comment, Nate? I did put 
> (Amruta Borkar via dili) at the end of the comment though...
>     
>     commit f6124a056d2a8ed16bec917775b9d3554ab5d74d
>     Author: Di Li <d...@apache.org>
>     Date:   Fri Oct 7 13:34:54 2016 -0400
>     
>         AMBARI-18355: Introduce conditional dependencies in stack defition to 
> handle blueprint validation gracefully (Amruta Borkar via dili)

No no, that was my mistake - my browser had cut off the comment so all I saw 
the author's name.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review151861
-----------------------------------------------------------


On Oct. 12, 2016, 7:42 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51815/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 7:42 p.m.)
> 
> 
> Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
> Marron, Laszlo Puskas, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18355
>     https://issues.apache.org/jira/browse/AMBARI-18355
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently stack definitions do not list conditional dependencies, adding 
> those to the stack definitions would make it easy to validate errors in case 
> of blueprint deployment. Please refer to document attached to Jira
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionAdapter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java
>  e3db662 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  a5f33ff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 65d166a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  ff9af17 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b1de8ef 
> 
> Diff: https://reviews.apache.org/r/51815/diff/
> 
> 
> Testing
> -------
> 
> Written Junit test cases. Perfomred manual testing to check the Namenode HA 
> component dependency. Was able to proceed with the installation for valid 
> blueprint. and got validation error message while registering blueprint when 
> the Blueprint did not satisfy the conditional dependencies.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Reply via email to