> On Oct. 13, 2016, 1:24 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml, > > lines 43-47 > > <https://reviews.apache.org/r/51815/diff/5/?file=1533651#file1533651line43> > > > > This is a bit of an odd syntax. the <condition> element should be a > > different class then you don't need the <condition-type> element. Now, > > these metainfo.xml files don't have schema for validation, but java XML is > > able to use correct classes based on the element name. So for example, you > > would have two types such that: > > > > > > <conditions> > > <condition xsi:type="property-exists"> > > <elements for property-exists> > > </condition> > > <condition xsi:type="property-equals"> > > <elements for property-equals> > > </condition> > > > > </conditions>
Hello Nate, Could you please provide your feedback on the updated patch? Thank you, Amruta - Amruta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review152489 ----------------------------------------------------------- On Nov. 1, 2016, 6:57 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51815/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 6:57 p.m.) > > > Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo > Marron, Laszlo Puskas, Nate Cole, and Robert Nettleton. > > > Bugs: AMBARI-18355 > https://issues.apache.org/jira/browse/AMBARI-18355 > > > Repository: ambari > > > Description > ------- > > Currently stack definitions do not list conditional dependencies, adding > those to the stack definitions would make it easy to validate errors in case > of blueprint deployment. Please refer to document attached to Jira > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java > e3db662 > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > a5f33ff > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > 9c1387d > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java > ff9af17 > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > b1de8ef > > Diff: https://reviews.apache.org/r/51815/diff/ > > > Testing > ------- > > Written Junit test cases. Perfomred manual testing to check the Namenode HA > component dependency. Was able to proceed with the installation for valid > blueprint. and got validation error message while registering blueprint when > the Blueprint did not satisfy the conditional dependencies. > > > Thanks, > > Amruta Borkar > >
