> On Dec. 17, 2015, 9:07 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > line 142 > > <https://reviews.apache.org/r/41473/diff/2/?file=1167624#file1167624line142> > > > > Is there a reason that > > `o.a.aurora.scheduler.configuration.executor.ExecutorSettingsLoader#ExecutorConfig` > > exists in addition to > > `o.a.aurora.scheduler.configuration.executor.ExecutorConfig`? They seem to > > be identical classes, am I missing something? > > Renan DelValle wrote: > This has to do with the JSON parsing. I think Bill will be able to answer > this question a little bit better than me but here's the comment on top of it: > "The JSON schema. This is separated from the public {@link > ExecutorConfig} so we can read objects that do not have all fields required > by the protobuf set in the JSON config."
I think this was just a mistake on my part. The decoupling Renan mentions above should have been handled with `ExecutorSettingsLoader.Schema`. I have https://reviews.apache.org/r/41523/ out to remove the duplicate `ExecutorConfig`. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/#review110964 ----------------------------------------------------------- On Dec. 16, 2015, 4:34 p.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41473/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 4:34 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Patch to allow Aurora to accept an executor config via commandline which > overrides the default thermos one. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > d04763418f55aa1e9f1b537987d21920c05fd950 > > Diff: https://reviews.apache.org/r/41473/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Renan DelValle > >
