> On March 21, 2016, 7:28 p.m., Joshua Cohen wrote: > > Does anyone think it would make sense to add a task w/ a final process to > > the e2e suite to avoid future breakages like this in the future?
+1. Given how much time it took us to investigate, it would be imprudent to ship it without a good test in place. One possibility could be crafting a finalizing task into our test job. That task could just print "OK" into stderr and the test would just curl it from http://localhost:1338/logs/<task_id>/finalizing_task/0/stderr. You can get task_id from aurora_admin (see test_observer_ui for example). - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124628 ----------------------------------------------------------- On March 21, 2016, 6:36 p.m., Amol Deshmukh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45115/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 6:36 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1642 > https://issues.apache.org/jira/browse/AURORA-1642 > > > Repository: aurora > > > Description > ------- > > AURORA-1642: Fix for broken finalization in Thermos runner. > > > Diffs > ----- > > src/main/python/apache/thermos/core/process.py > f147af7d0e84309691c135c8057a597379fa83e7 > src/test/python/apache/thermos/core/test_process.py > c339c91eb24616c8d640877ef088f659523d2bf5 > > Diff: https://reviews.apache.org/r/45115/diff/ > > > Testing > ------- > > # End to end tests > ``` > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ... > *** OK (All tests passed) *** > ``` > > # Python unit tests > ``` > $ ./pants test src/test/python:: > ... > 663 passed, 5 skipped, 1 warnings in 180.34 seconds > > ``` > > # Also tested using a test job in vagrant to ensure that "final" processes > are executed as expected using this job definition: > https://gist.github.com/adeshmukh/697d013dec64498a3942 > > > Thanks, > > Amol Deshmukh > >
