----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124891 -----------------------------------------------------------
Ship it! src/main/python/apache/thermos/core/process.py (line 521) <https://reviews.apache.org/r/45115/#comment187587> drop extra "the" src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora (line 39) <https://reviews.apache.org/r/45115/#comment187590> you can drop this line as default `instances` is already set to 1 - Maxim Khutornenko On March 22, 2016, 9:04 p.m., Amol Deshmukh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45115/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 9:04 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1642 > https://issues.apache.org/jira/browse/AURORA-1642 > > > Repository: aurora > > > Description > ------- > > Ensure final processes are executed when ephemeral daemon processes exist. > > > Diffs > ----- > > src/main/python/apache/thermos/core/process.py > f147af7d0e84309691c135c8057a597379fa83e7 > src/test/python/apache/thermos/core/test_process.py > c339c91eb24616c8d640877ef088f659523d2bf5 > src/test/sh/org/apache/aurora/e2e/ephemeral_daemon_with_final.aurora > PRE-CREATION > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > b469f9bbbdfbf98df947832411bd0cdce97affdc > > Diff: https://reviews.apache.org/r/45115/diff/ > > > Testing > ------- > > # End to end tests > ``` > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ... > *** OK (All tests passed) *** > ``` > > # Python unit tests > ``` > $ ./pants test src/test/python:: > ... > 663 passed, 5 skipped, 1 warnings in 180.34 seconds > > ``` > > # Also tested using a test job in vagrant to ensure that "final" processes > are executed as expected using this job definition: > https://gist.github.com/adeshmukh/697d013dec64498a3942 > > > Thanks, > > Amol Deshmukh > >
