-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review128683
-----------------------------------------------------------



Thanks for following up - the source change from github to apache's download 
redirector service was a good idea and it seems a more appropriate source to 
boot!

This worked for me using `./build-artifact.sh /tmp/snapshot.tar.gz 0.13.0` only 
after:
```diff
diff --git a/specs/rpm/Makefile b/specs/rpm/Makefile
index 0476bcb..950f91e 100644
--- a/specs/rpm/Makefile
+++ b/specs/rpm/Makefile
@@ -21,7 +21,7 @@ DATETIME ?= $(shell date +%Y%m%d%H%M)
 AURORA_VERSION ?= $(shell cat $(TOPDIR)/.auroraversion | tr '-' '.')
 MESOS_VERSION ?= $(shell tr -d "'\" \t" < $(TOPDIR)/3rdparty/python/BUILD | 
sed -n 's/MESOS_REV=(.*)/\1/p' )
 
-SOURCE_TARGET ?= $(RPM_TOPDIR)/rpmbuild/SOURCES/$(AURORA_VERSION).tar.gz
+SOURCE_TARGET ?= 
$(RPM_TOPDIR)/rpmbuild/SOURCES/apache-aurora-$(AURORA_VERSION).tar.gz
 
 PHONY: all nightly_version release_version get_source_target clean mkdir srpm 
nightly_srpm nightly_rpm release_srpm release_rpm tar_source
```

If you add that change and rebase (there were changes to the removed/moved 
pants.ini in https://reviews.apache.org/r/45662/) - this change LGTM and I'll 
patch it in.

- John Sirois


On April 13, 2016, 4:47 a.m., Pierre Cheynier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 4:47 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -----
> 
>   builder/deb/debian-jessie/Dockerfile 
> 63e89deed9a411b1859ba28ea2572ef4a210da1f 
>   builder/deb/debian-jessie/pants.ini 
> 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 52739100c9593292a7aea2459412c8e49f0155a4 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> -------
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Reply via email to