-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review52220
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/25255/#comment90978>

    Why not reuse the existing "update" verb? Having "supdate" just to avoid 
naming collision with the existing verb that will go away soon does not seem 
well justified.



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/25255/#comment90962>

    How about a BROWSER_OPTION for all update commands 
(start/pause/resume/abort)?



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/25255/#comment90972>

    Just realized we are missing cron-check on the server side 
(https://reviews.apache.org/r/25311/). You might want to do a similar check 
here to short circuit  server call and provide a custom error message hinting 
users to use "aurora cron" commands.



src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/25255/#comment90974>

    Is this a result of sharing the verb definition with start_update? Any 
chance to avoid sharing the option set here?


- Maxim Khutornenko


On Sept. 2, 2014, 4:36 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25255/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 4:36 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change contains the basic commands needed to work with the
> scheduler-driven updater. (It does not yet cover querying for the status
> of the update; that will come in a subsequent change.)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 51c7d24dca664e476e62f1864d095416dfab70e4 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
>   src/test/python/apache/aurora/client/cli/BUILD 
> e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> a1e7a5a94a2d336239df98e2600658b97c546901 
>   src/test/python/apache/aurora/client/cli/test_supdate.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> 95a2123e127c9811fd2305e71cfc5c7c4376f904 
> 
> Diff: https://reviews.apache.org/r/25255/diff/
> 
> 
> Testing
> -------
> 
> New suite of tests for the new command; all unit tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to