> On Sept. 2, 2014, 1:32 p.m., Joshua Cohen wrote:
> > Is the command name "supdate" up for debate? I'm not in love with it ;).

It's a temporary thing. (Came up with it during a discussion with Bill.) 

If we start adding this stuff to the existing update command, then existing 
users are going to see things like "pause", and "resume" that don't make any 
sense, and that are only related to a component/service that they can't use.  
We don't want to screw up or confuse users of the existing command during the 
development of the update service - so for that transition, we're keeping 
update/supdate separate.

I'm not in love with "supdate" as the name, but I didn't want to waste time 
coming up with something better when it's just temporary anyway.


> On Sept. 2, 2014, 1:32 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/jobs.py, lines 664-665
> > <https://reviews.apache.org/r/25255/diff/1/?file=673959#file673959line664>
> >
> >     This doesn't read very well to me.
> >     
> >     Maybe something like:
> >     
> >     "Update action to start an update or pause, resume or abort an 
> > in-progress update."

I think that wording is worse... The help should suggest what the value of the 
parameter is. "Update action to start an update or pause..." blurs that. The 
argument specifies the action that the user wants, which can be update, pause, 
resume, or abort.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25255/#review52043
-----------------------------------------------------------


On Sept. 2, 2014, 12:36 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25255/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2014, 12:36 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change contains the basic commands needed to work with the
> scheduler-driven updater. (It does not yet cover querying for the status
> of the update; that will come in a subsequent change.)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 51c7d24dca664e476e62f1864d095416dfab70e4 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
>   src/test/python/apache/aurora/client/cli/BUILD 
> e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> a1e7a5a94a2d336239df98e2600658b97c546901 
>   src/test/python/apache/aurora/client/cli/test_supdate.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> 95a2123e127c9811fd2305e71cfc5c7c4376f904 
> 
> Diff: https://reviews.apache.org/r/25255/diff/
> 
> 
> Testing
> -------
> 
> New suite of tests for the new command; all unit tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to