> On Sept. 3, 2014, 3:58 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 667 > > <https://reviews.apache.org/r/25255/diff/1/?file=673959#file673959line667> > > > > How about a BROWSER_OPTION for all update commands > > (start/pause/resume/abort)?
It will, eventually, but we don't have a set URL for it yet. That can be added when the UI is more locked down. > On Sept. 3, 2014, 3:58 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 704-706 > > <https://reviews.apache.org/r/25255/diff/1/?file=673959#file673959line704> > > > > Is this a result of sharing the verb definition with start_update? Any > > chance to avoid sharing the option set here? With the way that the noun/verb framework works right now, no, there's not really any good way. There are three choices: (1) Have an action parameter as a selector (what this change does); (2) Have a collection of verbs, "update_start", "update_pause", "update_resume", "update_abort". (3) Add a noun for an in-progress update, in which case the commands become "aurora update start", "aurora update pause", etc. I really hate (2), and I've been going back and forth between (1) and (3). - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/#review52220 ----------------------------------------------------------- On Sept. 2, 2014, 12:36 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25255/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 12:36 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > This change contains the basic commands needed to work with the > scheduler-driven updater. (It does not yet cover querying for the status > of the update; that will come in a subsequent change.) > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/context.py > 51c7d24dca664e476e62f1864d095416dfab70e4 > src/main/python/apache/aurora/client/cli/jobs.py > ebc22aaa5a8aed311897b3ce9632b6f7175b6080 > src/test/python/apache/aurora/client/cli/BUILD > e1f9ebf96774b8f5c75de8570c6ba87d953ab649 > src/test/python/apache/aurora/client/cli/test_restart.py > a1e7a5a94a2d336239df98e2600658b97c546901 > src/test/python/apache/aurora/client/cli/test_supdate.py PRE-CREATION > src/test/python/apache/aurora/client/cli/util.py > 95a2123e127c9811fd2305e71cfc5c7c4376f904 > > Diff: https://reviews.apache.org/r/25255/diff/ > > > Testing > ------- > > New suite of tests for the new command; all unit tests pass. > > > Thanks, > > Mark Chu-Carroll > >
