> On Feb. 12, 2015, 4:41 p.m., David McLaughlin wrote:
> > docs/thrift-deprecation.md, line 20
> > <https://reviews.apache.org/r/29117/diff/4/?file=862696#file862696line20>
> >
> >     Sorry I missed this first review, but AFAIK this isn't true for dynamic 
> > languages (incl. our own scheduler UI)?
> 
> Maxim Khutornenko wrote:
>     Can you elaborate? The above statement assumes renaming the field 
> throughout the codebase (including java, python and JS). Current +- 1 
> versions of client will still be able to communicate with the scheduler. UI 
> ships with the scheduler and thus will not have the renaming problelm. What 
> am I missing?

Yeah, and even an old version of the UI is still using TJSONProtocol so it's 
decoding the field number to its own mapping of names. So as long as it's 
consistent with itself it's fine.

If a downstream consumer updates its IDL then yes it'll need to change the name 
too.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29117/#review72291
-----------------------------------------------------------


On Feb. 12, 2015, 4:35 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29117/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 4:35 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-973
>     https://issues.apache.org/jira/browse/AURORA-973
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a first stab at documenting thrift deprecation. Any 
> suggestions/comments are welcome.
> 
> 
> Diffs
> -----
> 
>   docs/developing-aurora-client.md e002d908ce07020513fa06c7e70c41f9e2f55b1d 
>   docs/developing-aurora-scheduler.md 
> 7f6cc2e6c8e01115a9b7a7dc7633bcd88ba02a0f 
>   docs/thrift-deprecation.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29117/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/populated_deprecation/docs/thrift-deprecation.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to