-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76832
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124498>

    This is a duplicate of the 'PartialJobKey' class in client/cli/jobs.py. 
Please consider reusing that class to prevent duplication.
    
    Ideally you do this so your 'update_filter' function can be reused for 
parsing these CLI values.



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124499>

    No need for .dedent here.


- Zameer Manji


On March 17, 2015, 1:50 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 1:50 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: AURORA-1168
>     https://issues.apache.org/jira/browse/AURORA-1168
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Change "update list" subcommand to accept a hierarchy.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> f025d46d50592156e2455313890e981722ab63a5 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> cb66439a778349fc5add4985a7395655c9e1328a 
> 
> Diff: https://reviews.apache.org/r/32171/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to