> On March 17, 2015, 10:46 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 226
> > <https://reviews.apache.org/r/32171/diff/1/?file=898128#file898128line226>
> >
> >     This is a duplicate of the 'PartialJobKey' class in client/cli/jobs.py. 
> > Please consider reusing that class to prevent duplication.
> >     
> >     Ideally you do this so your 'update_filter' function can be reused for 
> > parsing these CLI values.

I initially looked into sharing code, but the use cases are different.  For 
example, `PartialJobkey` and relevant code supports wildcards, which i do not 
wish to support here.  Given that the behavior was different, i did not feel 
that sharing the one-liner for the namedtuple was constructive.


[1] 
https://github.com/apache/incubator-aurora/blob/2f991069e60e47ddbbaf1d60d6403922bbb0e208/src/main/python/apache/aurora/client/cli/jobs.py#L68-L87


> On March 17, 2015, 10:46 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 281
> > <https://reviews.apache.org/r/32171/diff/1/?file=898128#file898128line281>
> >
> >     No need for .dedent here.

Removed.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76832
-----------------------------------------------------------


On March 17, 2015, 8:50 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 8:50 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: AURORA-1168
>     https://issues.apache.org/jira/browse/AURORA-1168
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Change "update list" subcommand to accept a hierarchy.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> f025d46d50592156e2455313890e981722ab63a5 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> cb66439a778349fc5add4985a7395655c9e1328a 
> 
> Diff: https://reviews.apache.org/r/32171/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to