> On March 18, 2015, 12:03 a.m., David McLaughlin wrote:
> > src/test/python/apache/aurora/client/cli/test_supdate.py, line 408
> > <https://reviews.apache.org/r/32171/diff/2/?file=898419#file898419line408>
> >
> >     This is more of a general concern, but it would be nice to avoid adding 
> > new tests in this style - and instead test the Command instance directly. I 
> > can't find the actual back and forth that led me to testing like this, but 
> > it was introduced here: https://reviews.apache.org/r/27848/diff/#

Nearly forgot to address this.  Patch incoming that moves all test cases for 
this command to the new style.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76853
-----------------------------------------------------------


On March 19, 2015, 8:22 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 8:22 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: AURORA-1168
>     https://issues.apache.org/jira/browse/AURORA-1168
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> NOTE: I also am proposing with this change that the output format of `aurora 
> update list` be line-oriented and more concise (see test changes for 
> examples).  The idea is to follow up ~immediately with AURORA-1206.  The 
> proposal is for this command to let you retrieve update identifiers, and 
> `update status` (whose name may change) will allow you to drill into updates.
> 
> I'm open to input on this.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> f025d46d50592156e2455313890e981722ab63a5 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> cb66439a778349fc5add4985a7395655c9e1328a 
> 
> Diff: https://reviews.apache.org/r/32171/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to