-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77102
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124993>

    How about a special "blocked" group to display only the updates blocked due 
to lack of heartbeat? Could be quite useful for monitoring of blocked updates.



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124992>

    Move to previous line?



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124997>

    Recommend adding a phrase explaining the behavior in case multiple 
groups/statuses are specified.



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124999>

    While it's converted to set by thrift anyway, I'd still recommend using a 
set() here to explicitly assert no duplicates are ever accepted.


- Maxim Khutornenko


On March 19, 2015, 9:09 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 9:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: AURORA-1168
>     https://issues.apache.org/jira/browse/AURORA-1168
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> NOTE: I also am proposing with this change that the output format of `aurora 
> update list` be line-oriented and more concise (see test changes for 
> examples).  The idea is to follow up ~immediately with AURORA-1206.  The 
> proposal is for this command to let you retrieve update identifiers, and 
> `update status` (whose name may change) will allow you to drill into updates.
> 
> I'm open to input on this.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> f025d46d50592156e2455313890e981722ab63a5 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> cb66439a778349fc5add4985a7395655c9e1328a 
> 
> Diff: https://reviews.apache.org/r/32171/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to