jiajunwang commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r352956641
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -158,7 +162,7 @@ private void joinCluster() {
}
}
- private void createLiveInstance() {
+ private void createLiveInstance(final String sessionId) {
Review comment:
I realized when reviewing the later code that you don't need to pass the
sessionId. Correct me if I am wrong, I think you can just pass _sessionId into
the createEphemeral().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
