jiajunwang commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r352955778
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -858,21 +931,30 @@ private void reconnect() {
}
}
- private void fireNewSessionEvents() {
+ private void fireNewSessionEvents(final String sessionId) {
Review comment:
I guess we don't need to pass the session Id from the event. If this change
is for the event queue to discard the stale events, then I'm fine. But it seems
to be not the case.
The logic in this PR, in short, should be ensuring the node was always
created by the session Id in the manager, right? In that case, we don't really
care which event triggers the new session handling.
It seems that we have not done the old events discarding yet? I strongly
suggest doing that first. That solved 99% of the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
