jiajunwang commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r352954997
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -1129,13 +1134,13 @@ public void handleNewSession() throws Exception {
switch (_instanceType) {
case PARTICIPANT:
- handleNewSessionAsParticipant();
+ handleNewSessionAsParticipant(sessionId);
break;
case CONTROLLER:
handleNewSessionAsController();
Review comment:
I know we probably don't want to change the controller side logic, but
please add a TODO since we shall do the same for both sides.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
