jiajunwang commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r352957677
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -521,6 +543,11 @@ public String create(final String path, Object data,
final CreateMode mode)
*/
public String create(final String path, Object datat, final List<ACL> acl,
final CreateMode mode)
throws IllegalArgumentException, ZkException {
+ return create(path, datat, acl, mode, null);
+ }
+
+ private String create(final String path, Object datat, final List<ACL> acl,
final CreateMode mode,
+ final String sessionId) throws IllegalArgumentException, ZkException {
Review comment:
nit: If this session Id does not match, we can fail the method early even
before retry loop starts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
