jiajunwang commented on a change in pull request #642: Fix zk session race
condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r353351425
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -158,7 +162,7 @@ private void joinCluster() {
}
}
- private void createLiveInstance() {
+ private void createLiveInstance(final String sessionId) {
Review comment:
I don't think so. If you pass the _sessionId as a parameter, even it is
changed later at random time by the manager logic, the parameter won't be
changed. Note that you are passing the String.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
