jiajunwang commented on a change in pull request #632: Asynchronously
calculating the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r360539683
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -121,14 +121,16 @@ public BestPossibleStateCalcStage(WagedRebalancer
wagedRebalancer) {
}
private WagedRebalancer getWagedRebalancer(HelixManager helixManager,
- Map<ClusterConfig.GlobalRebalancePreferenceKey, Integer> preferences) {
+ Map<ClusterConfig.GlobalRebalancePreferenceKey, Integer> preferences,
+ boolean isAsyncGlobalRebalance) {
// Create WagedRebalancer instance if it hasn't been already initialized
if (_wagedRebalancer == null) {
- _wagedRebalancer = new WagedRebalancer(helixManager, preferences);
+ _wagedRebalancer = new WagedRebalancer(helixManager, preferences,
isAsyncGlobalRebalance);
} else {
- // Since the preference can be updated at runtime, try to update the
algorithm preference
- // before returning the rebalancer.
- _wagedRebalancer.updatePreference(preferences);
+ // Since the rebalance configure can be updated at runtime, try to
update the rebalancer
Review comment:
The user just updates in the cluster config. Please consider this method as
internal usage only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
