jiajunwang commented on a change in pull request #632: Asynchronously
calculating the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r360539900
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -281,8 +283,10 @@ private boolean validateOfflineInstancesLimit(final
ResourceControllerDataProvid
Map<String, IdealState> newIdealStates = new HashMap<>();
+ ClusterConfig clusterConfig = cache.getClusterConfig();
WagedRebalancer wagedRebalancer =
- getWagedRebalancer(helixManager,
cache.getClusterConfig().getGlobalRebalancePreference());
+ getWagedRebalancer(helixManager,
clusterConfig.getGlobalRebalancePreference(),
+ clusterConfig.isGlobalRebalanceAsyncModeEnabled());
Review comment:
That's what you suggested, I also think it is a clean one : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
