i3wangyi commented on a change in pull request #662: Mitigate controller
leadership switch latency - improve leader -> standby
URL: https://github.com/apache/helix/pull/662#discussion_r375604765
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -780,13 +780,10 @@ public void disconnect() {
// TODO reset user defined handlers only
// TODO Fix the issue that when connection disconnected, reset handlers
will be blocked. -- JJ
- // This is because reset logic contains ZK operations.
- resetHandlers(true);
Review comment:
@jiajunwang I understand your concern. With the current helix structure &
library dependency, many times there's really no easy way to satisfy everything
while still keeping the code clean & short IMO, even we overall agree with the
overall design here. Let's take it offline.
I will try to resolve rest concerns as much as I could and propose a new
draft code structure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
