kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377982247
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/api/factory/RealmAwareZkClientFactory.java
##########
@@ -19,5 +19,14 @@
* under the License.
*/
+import org.apache.helix.zookeeper.api.api.client.RealmAwareZkClient;
+
+
+/**
+ * Creates an instance of RealmAwareZkClient.
+ */
public interface RealmAwareZkClientFactory {
+
+ RealmAwareZkClient buildZkClient(RealmAwareZkClient.MODE mode,
+ RealmAwareZkClient.RealmAwareZkClientConfig config);
Review comment:
Just a note, this means that we need to use the RealmAwareZkClientConfig to
generate HelixZkClient.ZkConnectionConfig.
HelixZkClient.ZkConnectionConfig is pair {zkServerAddress, sessiontimeout} .
zkServerAddress can be derived from shardingKey in RealAwareZkClientConfig.
However, sessiontimout can not.
So here, shall we do:
1/ add sessiontimeout to RealmAwareZkClientConfig?
or
2/ having another parameter to specify a sessiontimeout to the interface
method buildZkClient?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
