kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377992236
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/api/factory/RealmAwareZkClientFactory.java
##########
@@ -19,5 +19,14 @@
* under the License.
*/
+import org.apache.helix.zookeeper.api.api.client.RealmAwareZkClient;
+
+
+/**
+ * Creates an instance of RealmAwareZkClient.
+ */
public interface RealmAwareZkClientFactory {
+
+ RealmAwareZkClient buildZkClient(RealmAwareZkClient.MODE mode,
+ RealmAwareZkClient.RealmAwareZkClientConfig config);
Review comment:
Another high level question, in the scope of dedicatedZkClient or
sharedZkClient discussion, all the create ZkClient already are RealAware,
right? we don't really need to have a mode for user to specify.
The mode can be kept internally for the client to know. In fact, even this
(internally keep the type) may not be needed as we have new dedicatedZkClient
and new sharedZkClient which wraps sharedZkClient and zkclient as of now. The
type information is already encode in the class design. The beauty of OO
inheritance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
