kaisun2000 commented on a change in pull request #745: [WIP] Create
RealmAwareZkClientFactory interface
URL: https://github.com/apache/helix/pull/745#discussion_r377995356
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/impl/factory/HelixZkClientFactory.java
##########
@@ -28,7 +29,7 @@
/**
* Abstract class of the ZkClient factory.
*/
-abstract class HelixZkClientFactory {
+abstract class HelixZkClientFactory implements RealmAwareZkClientFactory {
Review comment:
In fact, after some thought, it seems to me that you only need a realm key
and keep the rest of HelixZkClientFactory intact would be fine. Let me draw
some psudeo-code to illustrate why this is true?
https://iwww.corp.linkedin.com/wiki/cf/display/ENGS/Project+ZooScalability%3A+ZkClient+API+Redesign
has pseudo code of RealmAwareZkClientFactory and HelixZkClientFactory to
illustrate this proposal.
I will think about how best reuse the current factory implementation code
and update the doc a little bit later,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
