kaisun2000 commented on a change in pull request #745: [WIP] Create RealmAwareZkClientFactory interface URL: https://github.com/apache/helix/pull/745#discussion_r377995356
########## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/impl/factory/HelixZkClientFactory.java ########## @@ -28,7 +29,7 @@ /** * Abstract class of the ZkClient factory. */ -abstract class HelixZkClientFactory { +abstract class HelixZkClientFactory implements RealmAwareZkClientFactory { Review comment: In fact, after some thought, it seems to me that you only need a realm key and keep the rest of HelixZkClientFactory intact would be fine. Let me draw some psudeo-code to illustrate why this is true? I will share a doc a little bit later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org