zhangmeng916 commented on a change in pull request #851: Add customized view
computation and modify Helix generic controller to include new stage
URL: https://github.com/apache/helix/pull/851#discussion_r390011688
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1072,6 +1152,25 @@ protected void
checkLiveInstancesObservation(List<LiveInstance> liveInstances,
}
}
+ for (String instance : curInstances.keySet()) {
Review comment:
The reason we need to add listeners in both functions is that only after
customized state config is updated, the paths of individual states can be
decided and listeners can be added to them. For example, after we add listener
in live instance change, if we do not add listener in customized state config,
we will miss the paths of the new customized state, and all the changes on this
path will be missed until next live instance change. This is not preferred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
