jiajunwang commented on a change in pull request #851: Add customized view
computation and modify Helix generic controller to include new stage
URL: https://github.com/apache/helix/pull/851#discussion_r391177042
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/CustomizedStateCache.java
##########
@@ -46,14 +46,9 @@ public CustomizedStateCache(ControlContextProvider
contextProvider) {
@Override
protected Set<PropertyKey> PopulateParticipantKeys(HelixDataAccessor
accessor,
- Map<String, LiveInstance> liveInstanceMap) {
+ Map<String, LiveInstance> liveInstanceMap, Set<String> restrictedKeys) {
Review comment:
I think we discussed to put the restrictedKeys to the CustomizedStateCache
constructor as a final field. So you don't need to add this to these methods?
The downside of the current design is that the current state cache will have to
keep the unnecessary input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
