jiajunwang commented on a change in pull request #851: Add customized view
computation and modify Helix generic controller to include new stage
URL: https://github.com/apache/helix/pull/851#discussion_r391178860
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/ParticipantStateCache.java
##########
@@ -57,10 +57,11 @@ public ParticipantStateCache(ControlContextProvider
controlContextProvider) {
* @param liveInstanceMap map of all liveInstances in cluster
* @return
*/
- public boolean refresh(HelixDataAccessor accessor, Map<String, LiveInstance>
liveInstanceMap) {
+ public boolean refresh(HelixDataAccessor accessor, Map<String, LiveInstance>
liveInstanceMap,
+ Set<String> restrictedKeys) {
Review comment:
Following the previous comment, I think this restrictedKeys can be a field
only for the customizedStateCache class. As long as we input it in the
constructor, we will be able to read it in the customizedStateCache class
method. For this parent class, it does no need to know it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
