alirezazamani commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r391335054
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -376,62 +614,158 @@ public Object removeRoutingTableChangeListener(
* @return
*/
public Collection<LiveInstance> getLiveInstances() {
- return _routingTableRef.get().getLiveInstances();
+ String key = getRoutingTableKey();
+ return _routingTableRef.get(key).get().getLiveInstances();
+ }
+
+ public Collection<LiveInstance> getLiveInstances(PropertyType propertyType) {
Review comment:
Well, I understand they are the same. However, we need a key for accessing
routingTableRefMap. Should I randomly pick one of the keys? It doesn't hurt
having this method. I removed one of the methods. Please let me know if that
answers your question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
