alirezazamani commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r391764915
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -376,62 +614,158 @@ public Object removeRoutingTableChangeListener(
* @return
*/
public Collection<LiveInstance> getLiveInstances() {
- return _routingTableRef.get().getLiveInstances();
+ String key = getRoutingTableKey();
+ return _routingTableRef.get(key).get().getLiveInstances();
+ }
+
+ public Collection<LiveInstance> getLiveInstances(PropertyType propertyType) {
+ String key = getRoutingTableKey(propertyType);
+ return _routingTableRef.get(key).get().getLiveInstances();
+ }
+
+ public Collection<LiveInstance> getLiveInstances(PropertyType propertyType,
String type) {
+ String key = getRoutingTableKey(propertyType, type);
+ return _routingTableRef.get(key).get().getLiveInstances();
}
/**
* Return all instance's config in this cluster.
* @return
*/
public Collection<InstanceConfig> getInstanceConfigs() {
- return _routingTableRef.get().getInstanceConfigs();
+ String key = getRoutingTableKey();
+ return _routingTableRef.get(key).get().getInstanceConfigs();
+ }
+
+ public Collection<InstanceConfig> getInstanceConfigs(PropertyType
propertyType) {
Review comment:
Ok I picked one of the keys and merge all of them to one API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
