alirezazamani commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r393385877
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -700,12 +1003,13 @@ public void queueEvent(NotificationContext context,
ClusterEventType eventType,
event.addAttribute(AttributeName.helixmanager.name(),
context.getManager());
event.addAttribute(AttributeName.changeContext.name(), context);
queueEvent(event);
-
- _monitor.increaseCallbackCounters(_eventQueue.size());
+ for (PropertyType propertyType : _monitorMap.keySet()) {
+
_monitorMap.get(propertyType).increaseCallbackCounters(_eventQueue.size());
Review comment:
Yes this could potentially be not ideal and have some room to improvement.
Based on this design (which we have one routerUpdater for all of the different
types), we have one queue/RouterUpdater per RoutingTableProvider. Even here we
are sharing the queue between them. Hence when we have hendle_event, we add
queue size to all of them regarding the type and content of the queue. This is
one of the drawbacks of having one RouterUpdater per RoutingTable. We can have
TODO for improvement here maybe? What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
