jiajunwang commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r393999380
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -237,7 +337,48 @@ public void shutdown() {
* @return snapshot of current routing table.
*/
public RoutingTableSnapshot getRoutingTableSnapshot() {
- return new RoutingTableSnapshot(_routingTableRef.get());
+ String key = getRoutingTableKey(DEFAULT_PROPERTY, DEFAULT_TYPE);
+ return new RoutingTableSnapshot(_routingTableRefMap.get(key).get());
Review comment:
It seems all the usage of getRoutingTableKey is for getting the table ref.
Why not change it to directly return the table that we find?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
