jiajunwang commented on a change in pull request #834: Complete the Routing 
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r394002219
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
 ##########
 @@ -338,14 +525,37 @@ public Object removeRoutingTableChangeListener(
     return getInstancesForResource(resourceName, state);
   }
 
+  public Set<InstanceConfig> getInstances(String resourceName, String state,
 
 Review comment:
   Just to confirm that, are we going to remove it or not? This one is 
duplicate to getInstancesForResource.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to