jiajunwang commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r394048676
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -700,12 +1003,13 @@ public void queueEvent(NotificationContext context,
ClusterEventType eventType,
event.addAttribute(AttributeName.helixmanager.name(),
context.getManager());
event.addAttribute(AttributeName.changeContext.name(), context);
queueEvent(event);
-
- _monitor.increaseCallbackCounters(_eventQueue.size());
+ for (PropertyType propertyType : _monitorMap.keySet()) {
+
_monitorMap.get(propertyType).increaseCallbackCounters(_eventQueue.size());
Review comment:
TODO is fine, but we need 2 items.
1. Split the monitor into 2. One is general router callback tracking. The
other one is for each type of tracking. Then we have the right numbers.
2. We may need to add more complexity to the customized view monitor for
each state type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
