kaisun2000 commented on a change in pull request #924: WIP: fix
ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r402537367
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1073,10 +1073,24 @@ protected void processStateChanged(WatchedEvent event)
{
fireStateChangedEvent(event.getState());
+ // This following is the case for sharedZkClient
if (!isManagingZkConnection()) {
+ /*
+ For SharedZkClient, we will not invoke fireNewSessionEvents and we will
invoke fireAllEvents
+ This keeps the same behavior as original SharedZkClient.
+ Invoking fireAllEvents is important to make sure HelixPropertyStore
working correctly.
+ */
+ if ((event.getState() == KeeperState.SyncConnected) &&
(!_isNewSessionEventFired) && (!"0"
+ .equals(getHexSessionId()))) {
+ fireAllEvents();
+ _isNewSessionEventFired = true;
+ } else if (event.getState() == KeeperState.Expired) {
+ _isNewSessionEventFired = false;
+ }
Review comment:
By they way, setting _isNewSessionEventFired = false should be above
reconnect(). Otherwise, maybe there is a small chance of race condition. In
reconnect() or current code, maybe we still have this race condition. Put it
ahead definitely don't.
```
} else if (event.getState() == KeeperState.Expired) {
_isNewSessionEventFired = false;
if (isManagingZkConnection()) {
reconnectOnExpiring();
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
