jiajunwang commented on a change in pull request #924: Fix ZkHelixPropertyStore
loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r405742254
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1101,7 +1104,10 @@ protected void processStateChanged(WatchedEvent event) {
fireAllEvents();
}
} else if (event.getState() == KeeperState.Expired) {
- reconnectOnExpiring();
+ _isNewSessionEventFired = false;
+ if (isManagingZkConnection()) {
Review comment:
As we moved the isManagingZkConnection closer to these methods, it might be
cleaner if we just move it inside reconnectOnExpiring() and
fireNewSessionEvents(). So we have better protection and the code looks cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
