pkuwm commented on a change in pull request #924: Fix ZkHelixPropertyStore
loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r405767321
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1101,7 +1104,10 @@ protected void processStateChanged(WatchedEvent event) {
fireAllEvents();
}
} else if (event.getState() == KeeperState.Expired) {
- reconnectOnExpiring();
+ _isNewSessionEventFired = false;
Review comment:
I was also thinking about the same concern. It should be fine as it is
protected by the eventLock. And also if reconnecting fails because of
IOException, the old/expired zk is kept, but the expired zk could not do
anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
