kaisun2000 commented on a change in pull request #974:
URL: https://github.com/apache/helix/pull/974#discussion_r425446188
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -525,7 +526,7 @@ public void invoke(NotificationContext changeContext)
throws Exception {
private <T extends HelixProperty> List<T> preFetch(PropertyKey key) {
if (_preFetchEnabled) {
- return _accessor.getChildValues(key);
+ return _accessor.getChildValues(key, true);
Review comment:
Note, if exception thrown. For this CallbackHandler, before this change,
partial read result would be feed to OnMessage() or OnWhatever; now,
onMessage() would not be called, instead, zkEvent would get an exception, catch
the exception nad do logging. This is what we want.
Then, in Molly's case, the timer thread can see exception too, right? The
thing is that I suspect that timer's internal thread may not schedule more
OnMessage() if the previous one has exception thrown. This needs to be tested
and verified. Otherwise, the timer thread may never work after exception thrown
if my suspicion is right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
