jiajunwang commented on pull request #974: URL: https://github.com/apache/helix/pull/974#issuecomment-628940291
> @jiajunwang, I guess you see my point. > The other thinking is to let this api throw exception explicitly and run all unit test to see if they are ok. But that can be very time consuming. > > I cannot review review each use case. I am willing to trust you made all the right choice. I will give you approval. I have run all the unit test against the current change. But the main concern is that our unit test cannot cover all the scenarios. Hopefully, our stress test process will help to catch if anything left. But please let me know if any other practical tests that is in your mind. I'd like to run whatever test possible to ensure this is a safe change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
