kaisun2000 commented on pull request #974: URL: https://github.com/apache/helix/pull/974#issuecomment-628902348
I agree, partial result hide problem. But theoretically, now you can have an exception previously you don't. Now the problem is that this exception may not be caught properly and that would cause other problems like pipeline stopping, or thread get terminated etc. For these, we need to evaluate case by case. This is my point -- all the changed places, the potential exception is handled properly. Maybe you already considered them. Just a reminder. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
