dasahcc commented on a change in pull request #974:
URL: https://github.com/apache/helix/pull/974#discussion_r425456920
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
##########
@@ -186,7 +186,8 @@ private HelixDataAccessor getRecipientDataAccessor(final
Criteria recipientCrite
Map<String, String> sessionIdMap = new HashMap<String, String>();
if (recipientCriteria.isSessionSpecific()) {
Builder keyBuilder = targetDataAccessor.keyBuilder();
- List<LiveInstance> liveInstances =
targetDataAccessor.getChildValues(keyBuilder.liveInstances());
+ List<LiveInstance> liveInstances =
+ targetDataAccessor.getChildValues(keyBuilder.liveInstances(),
true);
Review comment:
I still not suggest to have this for DefaultMessaging service. Because
this changes behavior and it is used by customer. It may break their logic.
Except this one, others are in our control and should be fine for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
