dasahcc commented on a change in pull request #1127:
URL: https://github.com/apache/helix/pull/1127#discussion_r447317608
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/GenericBaseDataAccessorBuilder.java
##########
@@ -123,23 +124,26 @@ protected RealmAwareZkClient
createZkClient(RealmAwareZkClient.RealmMode realmMo
/**
* Validate ZkClientType based on RealmMode.
+ * If ZkClientType is DEDICATED or SHARED, the realm mode must be
SINGLE-REALM.
+ * If ZkClientType is FEDERATED, the realm mode must be MULTI-REALM.
* @param zkClientType
* @param realmMode
*/
private void validateZkClientType(ZkClientType zkClientType,
RealmAwareZkClient.RealmMode realmMode) {
- boolean isZkClientTypeSet = zkClientType != null;
- // If ZkClientType is set, RealmMode must either be single-realm or not
set.
- if (isZkClientTypeSet && realmMode ==
RealmAwareZkClient.RealmMode.MULTI_REALM) {
- throw new HelixException("ZkClientType cannot be set on multi-realm
mode!");
+ if (realmMode == null) {
Review comment:
Do we have some default mode for it? Shall we make it default behavior
as single realm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
